Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dmtrbch fxd 116 transfer ownership to dao #317

Open
wants to merge 3 commits into
base: xdc-prod-hardhat
Choose a base branch
from
Open

Dmtrbch fxd 116 transfer ownership to dao #317

wants to merge 3 commits into from

Conversation

dmtrbch
Copy link
Contributor

@dmtrbch dmtrbch commented Nov 15, 2024

No description provided.

TonioMacaronio
TonioMacaronio requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@TonioMacaronio TonioMacaronio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the contracts/main/dao should be the part of the codebase. If interaction is required - interfaces are enough. To run simulations - use as mocks. But not include into deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonioMacaronio TonioMacaronio TonioMacaronio requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmtrbch @TonioMacaronio